Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test with bundler module resolution #20629

Merged
merged 4 commits into from May 4, 2023
Merged

test: test with bundler module resolution #20629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42fb647
test: test with bundler module resolution
danielroe May 2, 2023
559c704
Merge branch 'main' into fix/bundler-resolution
danielroe May 4, 2023
00a4046
ci: test both node + bundler module resolution
danielroe May 4, 2023
4093a02
Merge branch 'main' into fix/bundler-resolution
danielroe May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -67,6 +67,10 @@ jobs:
timeout-minutes: 10
needs:
- build
strategy:
fail-fast: false
matrix:
module: ['bundler', 'node']

steps:
- uses: actions/checkout@v3
Expand All @@ -87,6 +91,8 @@ jobs:

- name: Test (types)
run: pnpm test:types
env:
MODULE_RESOLUTION: ${{ matrix.module }}

lint:
# autofix workflow will be triggered instead for PRs
Expand Down
4 changes: 1 addition & 3 deletions test/fixtures/basic/nuxt.config.ts
View file
Open in desktop
Expand Up @@ -15,9 +15,7 @@ export default defineNuxtConfig({
strict: true,
tsConfig: {
compilerOptions: {
// TODO: For testing (future) support for Node16-style module resolution.
// See https://github.com/nuxt/nuxt/issues/18426 and https://github.com/nuxt/nuxt/pull/18431
// moduleResolution: 'Node16'
moduleResolution: process.env.MODULE_RESOLUTION
}
}
},
Expand Down