Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): add apps to nuxt build-time instance #20637

Merged
merged 5 commits into from May 9, 2023
Merged

feat(nuxt): add apps to nuxt build-time instance #20637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0655a47
feat(nuxt): add nuxtApp to Nuxt
huang-julien May 2, 2023
71ecde1
fix: add default when loading Nuxt
huang-julien May 2, 2023
ed0f25c
feat: change to nuxt.apps
huang-julien May 3, 2023
af08844
refactor(nuxt): set `nuxt.app` directly after app creation
danielroe May 9, 2023
30d3031
Merge branch 'main' into feat/nuxt-and-nuxtapp
danielroe May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/nuxt/src/core/builder.ts
View file
Open in desktop
Expand Up @@ -11,6 +11,8 @@ import { generateApp as _generateApp, createApp } from './app'

export async function build (nuxt: Nuxt) {
const app = createApp(nuxt)
nuxt.apps.default = app

const generateApp = debounce(() => _generateApp(nuxt, app), undefined, { leading: true })
await generateApp()

Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/src/core/nuxt.ts
View file
Open in desktop
Expand Up @@ -37,7 +37,8 @@ export function createNuxt (options: NuxtOptions): Nuxt {
hook: hooks.hook,
ready: () => initNuxt(nuxt),
close: () => Promise.resolve(hooks.callHook('close', nuxt)),
vfs: {}
vfs: {},
apps: {}
}

return nuxt
Expand Down
2 changes: 2 additions & 0 deletions packages/schema/src/types/nuxt.ts
View file
Open in desktop
Expand Up @@ -23,6 +23,8 @@ export interface Nuxt {
server?: any

vfs: Record<string, string>

apps: Record<string, NuxtApp>
}

export interface NuxtTemplate<Options = Record<string, any>> {
Expand Down