Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): add types for webpack/vite environments #20749

Merged
merged 9 commits into from May 15, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 9, 2023

πŸ”— Linked issue

resolves #14131

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds asset typings and other environment types that are more precisely tailored to the builder the end user is using.

With #20748, When @nuxt/module-builder is detected, we can disable this so that our crafted types in @nuxt/schema/env can be used to prevent wrongly relying on features specific to just one of the builders (nuxt/framework#5376 (comment)).

We also avoid polluting the global context when importing from @nuxt/schema directly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented May 9, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

packages/schema/env.d.ts Outdated Show resolved Hide resolved
packages/schema/src/config/typescript.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from pi0 May 10, 2023 17:42
@danielroe danielroe added this to the v3.5 milestone May 11, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit pick: It is build(er) vs build-env. Othwrwise lgtm...

@danielroe danielroe merged commit 038c84c into main May 15, 2023
18 checks passed
@danielroe danielroe deleted the feat/asset-types branch May 15, 2023 16:17
This was referenced May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add asset import typings for webpack and vite builders
2 participants