Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): use runWithContext within callWithNuxt #20775

Merged
merged 1 commit into from May 11, 2023
Merged

feat(nuxt): use runWithContext within callWithNuxt #20775

merged 1 commit into from May 11, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This uses a new vue 3.3 feature for passing injection context when running Nuxt hooks or using unctx transform.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu May 11, 2023 08:40
@danielroe danielroe self-assigned this May 11, 2023
@codesandbox
Copy link

codesandbox bot commented May 11, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title feat: use runWithContext within callWithNuxt feat(nuxt): use runWithContext within callWithNuxt May 11, 2023
antfu
antfu approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@danielroe danielroe merged commit 93ba5e7 into main May 11, 2023
18 checks passed
@danielroe danielroe deleted the feat/vue-context branch May 11, 2023 11:39
This was referenced May 11, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @antfu