Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): avoid destructuring error prop (works around upstream bug) #20795

Merged
merged 4 commits into from May 11, 2023
Merged

fix(nuxt): avoid destructuring error prop (works around upstream bug) #20795

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78cbf16
docs: update lint command for the documentation
Lehoczky Apr 15, 2023
136304c
Merge branch 'nuxt:main' into main
Lehoczky Apr 19, 2023
93dd872
Merge branch 'nuxt:main' into main
Lehoczky May 11, 2023
e41d7e7
fix: error prop no longer undefined for Vue3.3
Lehoczky May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/nuxt/src/app/components/nuxt-error-page.vue
View file
Open in desktop
Expand Up @@ -5,12 +5,14 @@
<script setup>
import { defineAsyncComponent } from 'vue'

// Deliberately prevent reactive update when error is cleared
// eslint-disable-next-line vue/no-setup-props-destructure
const { error } = defineProps({
const props = defineProps({
error: Object
})

// Deliberately prevent reactive update when error is cleared
// eslint-disable-next-line vue/no-setup-props-destructure
Lehoczky marked this conversation as resolved.
Show resolved Hide resolved
const { error } = props

// TODO: extract to a separate utility
const stacktrace = (error.stack || '')
.split('\n')
Expand Down