fix(nuxt): allow pages:extend to enable pages module

[darioferderber]

🔗 Linked issue

resolves #20801

❓ Type of change

• 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Sets pages option to true if extendPages is called.
If extendPages gets called, it means that there are actually some pages, so we can set te pages option to true?

+ updates typo in documentation

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[nuxt-studio]

✅ Live Preview ready!

Name	Edit	Preview	Latest Commit
Nuxt Docs	Edit on Studio ↗︎	View Live Preview	d0b97a4

[edgarsn]

Thank you for your fast work, but I think there's one edge case left behind which is not my case, but may happen to others later.

You can also extend pages by using hook - pages:extend instead of extendPages() function.

Shouldn't it be better to set it after await nuxt.callHook('pages:extend', pages) here ? If pages array after hook call is not empty, then surely we can set nuxt.options.pages = true; right?

[darioferderber]

@edgarsn you're right!
this line you've mentioned will never get triggered in the dev mode, so it surely isn't a place to set nuxt.options.pages to true.

The problem is that isPagesEnabled function scans the pages directory before pages:extend hook is even called and returns if there are no pages (it returns too early).

I'll try to figure something out 🙂

Edit:
@danielroe are there any concerns if the hook gets called multiple times? Because I've tested it and even though the hook gets called multiple times, it won't push the same page into the array.

If it's like that, then the hook can be called inside the isPagesEnabled function, and that would eventually resolve the issue.

[danielroe]

The safest thing is probably to do this within isPagesEnabled, directly before returning false:

const pages = await resolvePagesRoutes()
await nuxt.callHook('pages:extend', pages)
if (pages.length) {
  return true
}

We can keep the previous early returns for true as a more performant fast-path.

[darioferderber]

I agree, but that means that the hook will be called multiple times if there are no pages, so I wasn't sure if that's a good idea.