fix(nuxt): transform client fallbacks directly on SFCs #20835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
May 13, 2023
| @@ -25,7 +25,7 @@ export const clientFallbackAutoIdPlugin = createUnplugin((options: LoaderOptions | |||
| if (include.some(pattern => id.match(pattern))) { | |||
| return true | |||
| } | |||
| return isVue(id, { type: ['template'] }) | |||
| return isVue(id) | |||
There was a problem hiding this comment.
it seems likely we need to update the isVue helper util to correctly identify template Vue imports within webpack, so we can preserve the performance improvement of restricting this transform to just vue templates.
There was a problem hiding this comment.
actually, I think your solution is right here, as we're directly replacing text in the SFC...
There was a problem hiding this comment.
i just begin to understand how it work,
here's a console.log(id, isVue(id), isVue(id, { type: ['template'] }) 🙂
danielroe
approved these changes
May 13, 2023
danielroe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #20833
❓ Type of change
📚 Description
Hi 👋 this PR fix an issue on
NuxtClientFallbackwith webpack only.The fallback dom node are not removed client-side. However i have no clue on why does
{ type: ['template'] }cause this issue📝 Checklist