New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(nuxt): use granular watcher to avoid crawling ignored dirs #20836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
1 similar comment
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
danielroe
added
the
π§· edge release
This PR will be released via the edge channel.
label
May 16, 2023
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
antfu
reviewed
May 18, 2023
antfu
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing idea! Love the approach!
Atinux
approved these changes
May 18, 2023
danielroe
changed the title
perf(nuxt): create granular watchers to avoid parsing entire file tree
perf(nuxt): use granular watcher to avoid crawling ignored dirs
May 18, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.x
bug
π§· edge release
This PR will be released via the edge channel.
π¨ p3-minor-bug
performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#12376
β Type of change
π Description
This follows up previous focus on watcher improvements (#20179) as a hybrid solution using
chokidar
- it filters out/ignores child directories withinsrcDir
directly. In tests in the monorepo, it reduces chokdar startup on a M1 Mac by 50%. I would expect even more significant performance improvements on a windows machine.To enable this you'll need to set
experimental.watcher
togranular
. (Otherwise behaviour will stay the same as currently.)I'd appreciate review - my main concern is whether we ought to make provision for users deliberately seeking to watch changes in
.nuxt
ornode_modules
(which they have enabled with a negative glob pattern inignore
).cc: @stafyniaksacha
π Checklist