New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): get fallback for <DevOnly>
from parsed html
#20840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Live Preview ready!
|
ineshbose
changed the title
fix(dev-only): split regex to allow < character
fix(dev-only-fallback): split regex to allow < character
May 14, 2023
8 tasks
ineshbose
changed the title
fix(dev-only-fallback): split regex to allow < character
fix(dev-only-fallback): get fallback from parser
May 14, 2023
An app.vue that should cover the bases to test: <script setup lang="ts">
</script>
<template>
<!-- Edit this file to play around with Nuxt but never commit changes! -->
<div>
Nuxt 3 Playground
<DevOnly>standard</DevOnly>
<DevOnly>
standard
<template #fallback>
<span>Fallback content</span>
</template>
</DevOnly>
<DevOnly>
<div>Element</div>
</DevOnly>
<DevOnly>
<div>Element</div>
<!-- comment -->
<template #fallback>Fallback content2</template>
</DevOnly>
<DevOnly>
Empty fallback
<!-- empty fallback -->
<template #fallback></template>
</DevOnly>
<DevOnly>
<div>dev only</div>
<ClientOnly>
client only
<div>client div</div>
<template #fallback>
<div>client fallback</div>
</template>
</ClientOnly>
<template #fallback>
<div>dev fallback</div>
</template>
</DevOnly>
</div>
</template>
<style scoped>
</style> |
ineshbose
force-pushed
the
dev-only-fallback
branch
from
May 14, 2023 21:08
9a3b50f
to
340478a
Compare
ineshbose
force-pushed
the
dev-only-fallback
branch
from
May 14, 2023 21:24
340478a
to
f29bc14
Compare
huang-julien
approved these changes
May 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π working wonderfully on my side
danielroe
approved these changes
May 15, 2023
danielroe
changed the title
fix(dev-only-fallback): get fallback from parser
fix(nuxt): get fallback content for May 15, 2023
<DevOnly>
from parsed html
danielroe
changed the title
fix(nuxt): get fallback content for
fix(nuxt): get fallback for May 15, 2023
<DevOnly>
from parsed html<DevOnly>
from parsed html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#20817 (comment)
β Type of change
π Description
It should now allow the documented example as well:
π Checklist