Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): pass from + savedPosition to first scrollBehavior #20859

Merged
merged 6 commits into from May 16, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #15568

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR ensures we only call scrollBehavior once on loading a new page, and we pass the saved position correctly through to it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(nuxt): pass saved position on to first call of scrollBehavior fix(nuxt): pass from + savedPosition to first scrollBehavior May 16, 2023
@danielroe danielroe merged commit a0583ba into main May 16, 2023
19 checks passed
@danielroe danielroe deleted the fix/router-scroll-start branch May 16, 2023 09:55
This was referenced May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrollBehavior gets called two times on initial page load
2 participants