Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix defaults in custom fetch example #20898

Merged
merged 1 commit into from May 16, 2023
Merged

docs: fix defaults in custom fetch example #20898

merged 1 commit into from May 16, 2023

Conversation

ExEr7um
Copy link
Contributor

@ExEr7um ExEr7um commented May 16, 2023

πŸ”— Linked issue

None.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

defu gives leftmost arguments the priority, so defaults should go right-side. Current solution gives defaults priority, so you can't rewrite them.

Quote from defu docs:

Leftmost arguments have more priority when assigning defaults.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title docs: fix defaults in useCustomFetch example docs: fix defaults in custom fetch example May 16, 2023
@danielroe danielroe merged commit 83cb5d6 into nuxt:main May 16, 2023
17 checks passed
This was referenced May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants