New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): prioritise vue app context when available #20910
Conversation
23a701c
to
082ed8f
Compare
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20910 |
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20910 |
/trigger release |
π Release triggered! You can now install nuxt@npm:nuxt3@pr-20910 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π―
@pi0 - Yes, that's the error code: https://github.com/nuxt/nuxt/actions/runs/5002108510/jobs/8961711745. |
π Linked issue
resolves #20741
related #19624 (comment)
proper fix will need to come vuejs/core#7743
β Type of change
π Description
Now that we have access to
hasInjectionContext
we can ensure we only check for current vue instance when we are within a component (orgetCurrentInstance
should fail).TODO:
π Checklist