Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): prioritise vue app context when available #20910

Merged
merged 8 commits into from May 17, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 17, 2023

πŸ”— Linked issue

resolves #20741
related #19624 (comment)
proper fix will need to come vuejs/core#7743

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Now that we have access to hasInjectionContext we can ensure we only check for current vue instance when we are within a component (or getCurrentInstance should fail).

TODO:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
Copy link
Member Author

/trigger release

@github-actions
Copy link
Contributor

πŸš€ Release triggered! You can now install nuxt@npm:nuxt3@pr-20910

@danielroe
Copy link
Member Author

/trigger release

@github-actions
Copy link
Contributor

πŸš€ Release triggered! You can now install nuxt@npm:nuxt3@pr-20910

@danielroe
Copy link
Member Author

/trigger release

@github-actions
Copy link
Contributor

πŸš€ Release triggered! You can now install nuxt@npm:nuxt3@pr-20910

@danielroe
Copy link
Member Author

The test failure we're experiencing is a validation of #15164, meaning that the Nuxt test fixture is a reproduction (cc: @pi0).

@danielroe danielroe marked this pull request as ready for review May 17, 2023 11:55
@danielroe danielroe requested a review from pi0 May 17, 2023 11:55
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ’―

@pi0
Copy link
Member

pi0 commented May 17, 2023

The test failure we're experiencing is a validation of #15164, meaning that the Nuxt test fixture is a reproduction (cc: @pi0).

I will test this afterwards if you can confirm only dev tests are failing for windows with 503

@danielroe
Copy link
Member Author

@pi0 - Yes, that's the error code: https://github.com/nuxt/nuxt/actions/runs/5002108510/jobs/8961711745.

@danielroe danielroe merged commit d2e14b6 into main May 17, 2023
19 checks passed
@danielroe danielroe deleted the fix/ctx-priority-vue branch May 17, 2023 12:26
This was referenced May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-site request pollution with useAsyncData
2 participants