Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): skip middleware for islands components #20924

Merged
merged 4 commits into from May 20, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented May 17, 2023

πŸ”— Linked issue

fix #20897

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

hi πŸ‘‹ this PR skip middleware for Server components

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huang-julien huang-julien marked this pull request as ready for review May 18, 2023 21:28
@danielroe danielroe added the bug label May 19, 2023
@huang-julien huang-julien changed the title fix(nuxt): skip middleware when no url set from context in islandCtx fix(nuxt): skip middleware for islands components May 19, 2023
@danielroe danielroe merged commit 2d68045 into nuxt:main May 20, 2023
19 checks passed
This was referenced May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware on / are applied to server components
2 participants