Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): use default type for initial value for composables #20968

Merged
merged 6 commits into from May 20, 2023
Merged

fix(nuxt): use default type for initial value for composables #20968

merged 6 commits into from May 20, 2023
+65 −53

Conversation

aaharu
Copy link
Contributor

@aaharu aaharu commented May 20, 2023

🔗 Linked issue

#20967

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #20967

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(type): improve types for fetching with default fix(nuxt): use default type for initial value for composables May 20, 2023
danielroe
danielroe approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice work - thank you ❤️

@danielroe danielroe merged commit b88aab0 into nuxt:main May 20, 2023
19 checks passed
@github-actions github-actions bot mentioned this pull request May 20, 2023
Merged
@aaharu aaharu deleted the async-data-default-type branch May 21, 2023 14:06
@github-actions github-actions bot mentioned this pull request May 21, 2023
Merged
@qoo1476 qoo1476 mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types improvement to asyncData with the default option
2 participants
@aaharu @danielroe