Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): use resolvePath to handle edge cases for modules #20975

Merged
merged 2 commits into from May 20, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

follow-up on #20896
resolves #20883

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This follows up on #20896 to use resolvePath to handle other edge cases (like implicit /index of a module) that occur when installing modules.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this May 20, 2023
@danielroe danielroe merged commit 9807282 into main May 20, 2023
19 checks passed
@danielroe danielroe deleted the fix/resolve-path-module branch May 20, 2023 22:29
This was referenced May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run npm install with custom modules with Nuxt 3.5.0
1 participant