Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Grammar overhaul getting started #21040

Closed
wants to merge 2 commits into from

Conversation

GalacticHypernova
Copy link
Contributor

πŸ”— Linked issue

The splitting of #20636 into smaller chunks

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Smaller chunk of the overhaul for easier reviewing and implementation

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link

nuxt-studio bot commented May 24, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview cfd568e

@GalacticHypernova GalacticHypernova changed the title Grammar overhaul getting started docs: Grammar overhaul getting started May 24, 2023
@GalacticHypernova
Copy link
Contributor Author

GalacticHypernova commented May 24, 2023

@danielroe @DamianGlowala Hope this is small enough! If not please do let me know and I'll release it in batches of 2-3 files at a time. Also sorry for my absence with this PR, was caught up with life.

@danielroe
Copy link
Member

I think we should close this PR as it is out of sync with the current docs.

A more general note: it's a mix of really good wording changes and ones that don't quite strike the right tone for me. Anything too extreme (like 'exquisite') I would avoid, as would changes that are largely equivalent to current values (like changing 'without learning TypeScript' to 'without having to learn TypeScript'). I'm aware this is very subjective.

Having said that, I would love to see this reopened as PRs targeting individual sections of the docs for easier (and faster πŸ™ˆ) review.

@danielroe danielroe closed this Apr 19, 2024
@danielroe danielroe mentioned this pull request Apr 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants