Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt): avoid watching nested paths #21256

Merged
merged 2 commits into from May 31, 2023
Merged

perf(nuxt): avoid watching nested paths #21256

merged 2 commits into from May 31, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #20596

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This handles an edge case, specifically when cloning a layer with a demo project located within it (like https://github.com/Atinux/content-wind/tree/main/.demo). Currently this means we don't properly benefit from the granular watcher pattern and exclude node_modules, .git and .cache folders within the subfolder.

Before watching a subfolder, this PR first checks whether it is a layer and if so skips creating the additional watcher.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes
Copy link
Contributor

Barbapapazes commented May 31, 2023

Hello Daniel,

It has been several times that there are performance issues on Windows. Do you think that it could be possible to have an automatic test to report it in the CI or It's too chaotic to test it? (like the test for the bundle size)

@danielroe
Copy link
Member Author

I would be very much up for any kind of performance testing if it can be done in a non-flaky way. πŸ‘

@Barbapapazes
Copy link
Contributor

Barbapapazes commented May 31, 2023

I would be very much up for any kind of performance testing if it can be done in a non-flaky way. πŸ‘

I tried to write some scripts but here my pain:

  • I want multiple runs in order to be able to do an average so I need to cleanup .nuxt folder. These runs must be one after the other.
  • I didn't find a satisfying solution to stop dev server a the good timing (using a spaw is far from ideal because of the complexity added )

@danielroe danielroe merged commit a302fe8 into main May 31, 2023
19 checks passed
@danielroe danielroe deleted the perf/nested-layers branch May 31, 2023 13:11
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt extremely slow on initial request
3 participants