Fix hmr server port #21344
Closed
Fix hmr server port #21344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to workout why I sometimes see this error, it doesn't appear to happen all the time |
|
HMR in the playground also seems to not work at all, even when I try locally on main 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21341 by removing some code that set vite's hmr port to24678everytime. In Vite 3 this pr set the default behaviour to use theclientPort(defaults to 3000 in nuxt) for HMR rather than a24678. Removing the code in nuxt's vite builder that set this port makes vite's default behaviour kick in causing #21341 to be fixed