Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): update vue-loader options type #21363

Merged
merged 3 commits into from Jun 4, 2023
Merged

fix(schema): update vue-loader options type #21363

merged 3 commits into from Jun 4, 2023

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Jun 4, 2023

πŸ”— Linked issue

#21332

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The schema for the vue-loader options did not extend the VueLoaderOptions interface and therefore the generated type, which the defineNuxtConfig function used was incorrect.

There are probably issues with other properties of the webpack.loaders object as well. They most likely should extend the option interface of their webpack plugin too. I can try to address this in another PR if you want, Daniel.

Before:
image

After:
image

Resolves #21332

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Lehoczky Lehoczky marked this pull request as ready for review June 4, 2023 21:53
@danielroe danielroe changed the title fix(schema): extend vue-loader options type fix(schema): update vue-loader options type Jun 4, 2023
@danielroe danielroe merged commit fd6a9b2 into nuxt:main Jun 4, 2023
22 checks passed
This was referenced Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend vue-loader option types
2 participants