-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): support custom route name meta with typedPages
#21659
fix(nuxt): support custom route name meta with typedPages
#21659
Conversation
Following @danielroe feedback, the route name resolver now uses estree parser to extract value from AST. Performance cost seem to be slightly higher on the tests I've made so far, I need to test with a bigger amount of pages to measure more precisely |
Updated with your latest advice @danielroe. Now AST parsing happens only if definePageMeta is defined, and happen only on the definePageMeta portion of code to minimize AST parsing. |
Would you mind taking a look at the failing CI? |
@danielroe Yep, I planned to have a look tomorrow |
Failing CI issue should be solved, unit tests now work properly with new implementation of Also new unit test implemented to cover route name override |
@danielroe Sorry to mention, I know it isn't ideal, but the new error on CI seems to be related to commits from main being merged to local branch. Considering the mature of the issue, I'm a bit confused on how I sould proceed to fix this.
|
The CI error is because you haven't added all the dependencies you're using to the package.json dependencies, and they are being inlined in the package output. |
β¦route-name-override
typedPages
typedPages
typedPages
π Linked issue
#21637
β Type of change
π Description
Resolves #21637 by parsing at build-time definePageMeta on routes & extracting custom route name
π Checklist