Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt):
usePreviewMode
composable #21705feat(nuxt):
usePreviewMode
composable #21705Changes from 15 commits
4906fe1
7610815
9460446
af690ad
ad612d8
dd48191
89c0c7f
be41ee5
10c29d5
ce664da
4c822ab
1cb89c8
8dc023a
53698e2
d06788d
46f10ce
f74ee68
7e181cc
9ee7aa6
b44c3fb
35c6d4f
3cea4c0
e496e1e
b61550f
c4f21cd
c17fa96
1a62917
f276b86
76bb35d
fb8d8d7
71dbe5a
fb10bea
bcea49b
addfd89
23b747b
63a38b9
ac96655
314e76c
7e0a09f
8775866
f6f9272
6c834ae
26f5dbb
59f0b57
0b6399b
0992713
a012a65
e318db0
e73707c
cb3f38a
0e736bb
47e2c4a
62314c8
951edd4
d634438
a43a184
2b2eb83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few ideas:
token
which I agree is the most common scenario, what do you think about setting arbitrary state?enabled
is manually set to false, we probably want to remove the refreshNuxtData router hook - maybe a computed ref with manual set/get values could be useful here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a little question, is there a point of something like
shouldEnable
if we give user ability to toggleon
andoff
preview mode ? I think of flagshouldAutoDetect
and if it istrue
, then detectpreview
in query (or we could say thatshouldAutoDetect
can beboolean
orstring
, if it is a string we will match for that string instead), iffalse
, let user manually do some detection (in for exampleonMounted
hook) and setenabled
to true ?