Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): respect false to disable spa loading template #21739

Merged
merged 2 commits into from Jun 25, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 24, 2023

πŸ”— Linked issue

#21721 (comment)
resolves #21745

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes a regression in the SPA loading template whereby setting it to false did not disable it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Jun 24, 2023
@danielroe danielroe merged commit 068ab19 into main Jun 25, 2023
28 checks passed
@danielroe danielroe deleted the fix/disable-spa-loading branch June 25, 2023 16:38
@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spaLoadingTemplate = false is not honored
1 participant