fix(nuxt): stop loading indicator on navigation failure

[huang-julien]

🔗 Linked issue

fix #21750

❓ Type of change

• 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR fixes #21750 on any navigation failure and when an router onError occurs

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

todo

• test fixtures

[danielroe]

Is it sufficient to use router.onError to solve the linked issue instead of adding a new hook?

[huang-julien]

oh nice point, I think we need both.

When using abortNavigation() without any argument, it returns false and doesn't throw so doesn't goes into the router.onError hook.

But when having an error argument, it does not goes within app:navigation:aborted hook because it returns false instead of throwing.

[huang-julien]

hmmm... that's the kind of PR i'd like to test with nuxt-vitest 😅

[nuxt-studio]

✅ Live Preview ready!

Name	Edit	Preview	Latest Commit
Nuxt Docs	Edit on Studio ↗︎	View Live Preview	b65fe38