Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): only redirect if path is not the same as initial url #21815

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #20491

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A regression was introduced in #20247 - namely, that it became impossible to add a new route and then redirect to it within the same request - this would become a redirection.

This adds a check that enables adding dynamic routes in this kind of way - we won't send a redirect to the same URL as the initial request.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL
Copy link
Member

manniL commented Jun 27, 2023

Good catch!

@danielroe danielroe merged commit 489b088 into main Jun 27, 2023
28 checks passed
@danielroe danielroe deleted the fix/allow-adding-routes branch June 27, 2023 10:15
@github-actions github-actions bot mentioned this pull request Jun 27, 2023
@CernyMatej
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicRoute from router.beforeEach in plugin: changed behaviour
3 participants