fix(nuxt, vite): do not use cjs utils to resolve/alias vue

[danielroe]

🔗 Linked issue

#14146

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Vite and Nitro correctly resolve vue dependencies, and it is far better to defer resolution to the bundlers than override it ourselves, particularly with support for non-hoist:

You can test with this plugin:

Details

const logger = {
  name: 'log',
  writeBundle (_options, bundle) {
    for (const file in bundle) {
      const chunk = bundle[file]
      if (chunk.type === 'asset') { continue }
      const resolvedVueFiles = chunk?.moduleIds.filter(i => i.includes('vue'))
      if (resolvedVueFiles?.length) {
        console.log(resolvedVueFiles)
      }
    }
  }
}

export default defineNuxtConfig({
  experimental: {
    // you can try with and without
    externalVue: false
  },
  nitro: {
    rollupConfig: {
      plugins: [logger]
    }
  },
  vite: {
    plugins: [logger]
  }
})

(In my testing, before this PR, with externalVue: false vue was actually being bundled twice in nitro bundle.)

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[pi0]

LGTM if you have already tested it against latest nitro.

We had to get rid of this workaround sooner or later.

Also linking to unjs/nitro#1118 which might be needed to dedup external vue

[danielroe]

I've tested it in the framework repo here. Are there module resolution changes coming upstream from nitro?

[pi0]

Are there module resolution changes coming upstream from nitro?

Only that we might start to apply runtime-keys worker conditions to worker targets which i don't think Vue is having them and should be fine..

[sei-jdshimkoski]

I think this might have broken this particular Nuxt Config setting (Nuxt 3.6.2 with Nitro 2.5.2):

vite: {
    build: {
      rollupOptions: {
        output: {
          manualChunks(_id) {
            return 'index'
          }
        },
      },
    },
  },

I now get a bunch of <BLAH> cannot be included in manualChunks because it is resolved as an external module by the "external" option or plugins.

[danielroe]

@sei-jdshimkoski Maybe you you could open an issue with reproduction? I don't have an issue with that code in a minimal sandbox.

[wtagain]

I think this might have broken this particular Nuxt Config setting (Nuxt 3.6.2 with Nitro 2.5.2):

vite: {
    build: {
      rollupOptions: {
        output: {
          manualChunks(_id) {
            return 'index'
          }
        },
      },
    },
  },

I now get a bunch of <BLAH> cannot be included in manualChunks because it is resolved as an external module by the "external" option or plugins.

Same question. Did you fix it?

[sei-jdshimkoski]

Sorry, was out of town and away from my computer. I'll try to open an issue with reproduction today.

[sei-jdshimkoski]

Ticket is here: #22127

[sei-jdshimkoski]

The only change in that minimal reproduction is the vite manualChunks setting in the nuxt config file.