fix(nuxt): add pages in correct hook when generating #22088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really looking forward to this PR! |
manniL
approved these changes
Jul 12, 2023
Merged
|
Hello @danielroe , Also please note the Content routes were also not generating, will this be resolved after this ? Awaiting your reply & this PR <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #22072
❓ Type of change
📚 Description
When updating Nuxt to use new Nitro static flag, we kept the existing
modules:donehook, which had already been called at this point, meaning page-produced routes were never added to prerender routes.This updates the logic so they will be correctly added when generating, either with
nuxi build --prerenderornuxi generate.📝 Checklist