-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): test watch
paths against all layer srcDir
s
#22307
Conversation
Run & review this pull request in StackBlitz Codeflow. |
So the problem is the watch is merged when using local layers, but the merge is using the relative path from project If we use the watch from the layers previous problem is solved, since the path will be relative to the layer |
On investigation, the change to absolute paths was a regression, now fixed in #22333. I think that means we should normalise watched paths to absolute in schema (as you're doing), and then re-normalise them to absolute and compare them against absolute path in I think we shouldn't need to do this per layer, but directly using Would you be able to update the PR, or would you prefer me do it? |
I'll try... |
watch
paths against all layer srcDir
s
π Linked issue
closes #22272
β Type of change
π Description
watch
option will be matched against the file path relative to the projectsrcDir
, this PR normalize thepath
received inbuilder:watch
to be relative to projectsrcDir
checking also against the normalized path.π Checklist