Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .devcontainer #22810

Merged
merged 7 commits into from
Sep 15, 2023
Merged

chore: add .devcontainer #22810

merged 7 commits into from
Sep 15, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 25, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Dev containers allow to locally develop and test nitro in isolated (Linux) docker containers.

Made this while locally testing cli issue with linux env. Might be worth to keep this setup in repo (also helps for windows users having a linux env)

https://code.visualstudio.com/docs/devcontainers/containers

Related experiment for nitro: nitrojs/nitro#1633

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

pi0 added 2 commits August 25, 2023 12:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@stackblitz
Copy link

stackblitz bot commented Aug 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pi0 pi0 changed the title chore: try with dev containers chore: try with vscode dev containers Aug 25, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely πŸ‘Œ

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pi0 pi0 changed the title chore: try with vscode dev containers chore: add .devcontainer Sep 15, 2023
@pi0 pi0 marked this pull request as ready for review September 15, 2023 07:50
@danielroe danielroe merged commit bdbb87a into main Sep 15, 2023
@danielroe danielroe deleted the chore/devcontainer branch September 15, 2023 10:09
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants