Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt): prevent head dom from rendering twice #22974

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Sep 3, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

With the move to immediately rendering the dom instead of debouncing it, we've introduced a regression in that the head will render to the DOM twice.

While the performance impact of this is reduced by quite a bit with Unhead 1.3, it's still not ideal and maybe adding ~5ms of extra load time.

The underlying issue is that we should wait for the suspense to resolve if we know the app is hydrating.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@harlan-zw harlan-zw changed the title perf: dom is rendered twice regression perf(nuxt): dom is rendered twice regression Sep 3, 2023
@harlan-zw harlan-zw changed the title perf(nuxt): dom is rendered twice regression perf(nuxt): head dom is rendered twice regression Sep 3, 2023
@danielroe danielroe changed the title perf(nuxt): head dom is rendered twice regression perf(nuxt): prevent head dom from rendering twice Sep 4, 2023
@danielroe danielroe merged commit 421cab1 into main Sep 4, 2023
25 checks passed
@danielroe danielroe deleted the perf/sync-head-regression branch September 4, 2023 08:12
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants