Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on node 20.5 rather than 20.6 #23041

Merged
merged 1 commit into from
Sep 6, 2023
Merged

ci: test on node 20.5 rather than 20.6 #23041

merged 1 commit into from
Sep 6, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 6, 2023

πŸ”— Linked issue

#23020
nodejs/node#49497

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This runs our CI on node 20.5 to avoid breakage in node 20.6 (example failed run: https://github.com/nuxt/nuxt/actions/runs/6096011429/job/16540685059?pr=23040).

Upstream solution has already been merged but I imagine it will likely take a while to filter back down to GHA runners, even after a hotfix release.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Sep 6, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit a998cb6 into main Sep 6, 2023
29 checks passed
@danielroe danielroe deleted the ci/node-20.5 branch September 6, 2023 11:15
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
@stafyniaksacha
Copy link
Contributor

@danielroe Node 20.6.1 seem to have fixed it: https://github.com/nodejs/node/releases/tag/v20.6.1
Maybe worth to use it?

@danielroe
Copy link
Member Author

it might take a moment before it's rolled out to github actions with node-version: 20, but I'll open a PR to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants