Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): include method when creating useFetch auto key #23086

Merged
merged 6 commits into from
Sep 11, 2023
Merged

fix(nuxt): include method when creating useFetch auto key #23086

merged 6 commits into from
Sep 11, 2023

Conversation

maximepvrt
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

manniL
manniL approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the use case for anything else than GET is rather rare, it seems like a good idea 👍

@Hebilicious
Copy link
Member

Even though the use case for anything else than GET is rather rare, it seems like a good idea 👍

Fun fact, I recently learned that there's way more registered HTTP method than I realised https://www.iana.org/assignments/http-methods/http-methods.xhtml

@danielroe danielroe changed the title fix: add http method to default useFetch key fix(nuxt): use fetch method to create useFetch auto key Sep 10, 2023
@danielroe danielroe changed the title fix(nuxt): use fetch method to create useFetch auto key fix(nuxt): include method when creating useFetch auto key Sep 11, 2023
@danielroe danielroe merged commit aa73cbe into nuxt:main Sep 11, 2023
25 checks passed
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@maximepvrt maximepvrt mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maximepvrt @Hebilicious @manniL @danielroe