Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): remove dev styles injected via absolute path #23126

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #22710

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We have an SSR-styles plugin that removes explicit stylesheets when developing. However, this was not removing them when they include an optional @fs param in the path (which seems triggered when path to CSS isn't the same as the path to root, such as with a custom srcDir or in a monorepo). This updates the code so we remove these stylesheets too.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit c045c4b into main Sep 11, 2023
25 checks passed
@danielroe danielroe deleted the fix/dupe-vite-dev-styles branch September 11, 2023 13:40
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate styles in development when srcDir is set
1 participant