Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): allow overriding components + only warn if clash #23156

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/content#2302, nuxt-themes/docus#972 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is yet another tweak to the duplicate component warning. We:

  1. allow overriding components if a newly scanned component has a higher priority. No warning is needed here; this is by design. (This does result in a behaviour change but I don't think it should affect most users as we already prioritised user content over layers, and that is also what the priority system does.)
  2. warn only if components are the same priority and are not layer components (which are designed to be overridden), namely have a priority of 1+

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 3e1ad3e into main Sep 12, 2023
25 checks passed
@danielroe danielroe deleted the fix/component-warning branch September 12, 2023 20:47
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant