Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): use rollup replace plugin for typeof optimisations #23903

Merged
merged 2 commits into from Nov 14, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#23859 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a prophylactic fix to keep compatibility with Vite 5.

Once vitejs/vite#11151 lands, we can consider using define to directly replace window with undefined for a more performant (and potentially better) solution.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from pi0 October 25, 2023 03:45
@danielroe danielroe changed the title fix(vite): use @rollup/plugin-replace for typeof optimisations fix(vite): use rollup replace plugin for typeof optimisations Nov 14, 2023
@danielroe danielroe merged commit 86693c1 into main Nov 14, 2023
33 checks passed
@danielroe danielroe deleted the fix/vite-define branch November 14, 2023 12:22
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant