fix(nuxt): wrap caught asyncData error in createError
#24093
Merged
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Nov 7, 2023
danielroe
approved these changes
Nov 8, 2023
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Bogdan Kostyuk <contact@bogdankostyuk.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR addresses a case when asyncData handler's promise gets rejected and the error isn't an instance of the
H3Errorclass. For instance, when watching the error property of the data fetching composable, it is currently triggered twice in this scenario. Firstly, it has a raw error value assigned, and only then an instance of H3Error, what leads to an inconsistent behavior.📝 Checklist