New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): allow customising logger options #24243
Conversation
Run & review this pull request in StackBlitz Codeflow. |
β Live Preview ready!
|
ca619d5
to
b8122dd
Compare
I like the idea π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea!
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #24243 +/- ##
=======================================
Coverage ? 58.76%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 506
Misses ? 355
Partials ? 0 β View full report in Codecov by Sentry. |
π Linked issue
This issues reported in unjs/consola and nuxt-modules/tailwindcss. Show that developers are struggleling with the possibility to pass level configuration to their plugins. I check in consola repository but everything is okay from their side, but our kit is not exposing a clear way to customize the logger.
unjs/consola#253
nuxt-modules/tailwindcss#732
β Type of change
π Description
Currently this implementaion only allowed to pass options when you are using a tag.
But is not allowed to passing options configuration only.
We can do it if you consider it as a better option.
π Checklist