New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): deeply unwrap headers/query for useFetch key #24307
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #24307 +/- ##
=======================================
Coverage ? 58.76%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 506
Misses ? 355
Partials ? 0 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Was thinking if we could use any faster method like JSON serialization but seems safe and fast with manual iteration as i expect these options are also small in size
wow that was fast π₯ |
π Linked issue
resolves #24294
resolves #24300
β Type of change
π Description
This makes sure we deeply unwrap headers/params objects when computing hash for automatic fetch key so we don't trigger a mismatch on client-side.
π Checklist