Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): capture and log island renderer errors #24356

Merged
merged 1 commit into from Nov 18, 2023
Merged

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

#24267

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hi πŸ‘‹
This is a small improvement for islands. Island errors are not logged, this can help our users to debug what's wrong.

Should this be made dev only ?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Nov 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@c444526). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24356   +/-   ##
=======================================
  Coverage        ?   58.76%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      506           
  Misses          ?      355           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@huang-julien huang-julien self-assigned this Nov 17, 2023
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I think it makes sense to log these errors in production as well. (Are the error messages totally swallowed otherwise?)

@huang-julien
Copy link
Member Author

Yes we can have [Vue warn]: Component <Anonymous> is missing template or render function. logged but the error itself is swallowed

@danielroe danielroe merged commit 7cce0ef into main Nov 18, 2023
33 checks passed
@danielroe danielroe deleted the fix/log-island-error branch November 18, 2023 20:47
@github-actions github-actions bot mentioned this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants