-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): server-only pages #24954
Merged
+109
β5
Merged
Changes from 36 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
0097fa4
wip test
huang-julien f35b414
feat: use current route path and remove component from preload
huang-julien 338d479
Merge branch 'main' into feat/server-page
huang-julien 283096d
fix: fix components.islands template
huang-julien a9caf7f
Merge remote-tracking branch 'origin/main' into feat/server-page
huang-julien 2dc1242
test: rename SugarCounter to Counter
huang-julien a9d3ae8
Merge remote-tracking branch 'origin/main' into feat/server-page
huang-julien 10ca60f
fix: stop loading indicator after server page end
huang-julien 446b67f
Merge remote-tracking branch 'origin/main' into feat/server-page
huang-julien 8afef3d
refactor: test by moving all to build time
huang-julien f939108
chore: lint
huang-julien 70c9809
chore: LINNNTTT
huang-julien a29d5c2
chore: LIIIIIIIIIIIIIIIIIIIINNNNNNNNTTTTTTTTTTT
huang-julien ce525f5
fix: correctly laod server page in runtime
huang-julien b0f2f3b
[autofix.ci] apply automated fixes
autofix-ci[bot] 0c2844b
fix: fix route file generation and introduce createIslandPage to handβ¦
huang-julien 4a55e8c
Merge branch 'feat/server-page' of https://github.com/nuxt/nuxt into β¦
huang-julien a763824
[autofix.ci] apply automated fixes
autofix-ci[bot] 9bc0e9b
fix: fix .server route detection
huang-julien 6123b66
Merge branch 'feat/server-page' of https://github.com/nuxt/nuxt into β¦
huang-julien 8703c28
[autofix.ci] apply automated fixes
autofix-ci[bot] 9a5c498
Merge branch 'main' into feat/server-page
huang-julien 807ff78
chore: cleanup
huang-julien b3b1947
docs: add meta data to docs
b69349d
Merge branch 'main' into feat/server-page
huang-julien ff927e1
chore: remove hook and remove spaces
huang-julien f0bdf48
fix: fix naming
huang-julien d0d0820
test: add basic test
huang-julien f7f8ef0
refactor: use mode like in the 25037 PR
huang-julien 685078d
[autofix.ci] apply automated fixes
autofix-ci[bot] 987e32c
fix(nuxt): fix serialization
huang-julien 81b13b5
Merge branch 'feat/server-page' of https://github.com/nuxt/nuxt into β¦
huang-julien b259749
fix: remove chunk comment
huang-julien 0e20478
chore: remove unwanted line/space changes
huang-julien 5292d9a
chore: add back tab
huang-julien b673a33
Apply suggestions from code review
huang-julien cfb5708
fix: move url path to context
huang-julien f40e653
Merge branch 'feat/server-page' of https://github.com/nuxt/nuxt into β¦
huang-julien bff2a85
docs: add warning about query not being send to server pages
huang-julien d969135
chore: update import
danielroe 67b697c
docs: update slightly
danielroe 9a29f0c
perf: use single dynamic import
danielroe a01b82e
Merge remote-tracking branch 'origin/main' into feat/server-page
danielroe 3207fd6
fix: allow setting 'all' as a mode
danielroe 51a30d7
perf: simplify
danielroe afd8cb8
refactor: only enable server pages at build with `.server.vue` and inβ¦
danielroe 2bbef5b
Merge remote-tracking branch 'origin/main' into feat/server-page
danielroe 948c374
fix: pass query for non-prerendered server pages
danielroe 3a1262a
fix: use route, not normalised page
danielroe 523d55e
perf: use more exact import
danielroe 6a64292
fix: don't pass attrs/props
danielroe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will make it much harder to cache server islands as the hash we create will vary by path.
Could we instead pass this as part of the context via
createIslandPage
instead (and maybe useroute.path
to skip query/hash)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not skip query π€, userss tend to relly on it within pages composables. Maybe can we pass an object like
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is (for example) that we will make a separate request for every query variation, which wouldn't be compatible with static sites and allow cache-busting by passing arbitrary query params or hashes ... (We should definitely not pass hash.) We could document this as a limitation of server pages... Or at a minimum, skip passing the full route if the route matches prerender routeRule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, let's start by passing only the path in the context then π€. and iterate on it, i'm not sure what kind of side effect we can have if using fullPath with ssg