Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): throw error if setInterval is used on server #25259

Merged
merged 9 commits into from
Jan 19, 2024
Merged

feat(nuxt): throw error if setInterval is used on server #25259

merged 9 commits into from
Jan 19, 2024
+19 −1

Conversation

atinux
Copy link
Member

@atinux atinux commented Jan 17, 2024

🔗 Linked issue

Resolves #25256

❓ Type of change

  • 👌 Enhancement (improving an existing functionality like performance)

📚 Description

Throw an error if using setInterval in the Vue app during SSR to avoid memory leaks or getting the node process stuck during nuxt generate.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).

Sorry, something went wrong.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jan 17, 2024
@atinux atinux changed the title chore(dx): mock setInterval for Vue app during SSR chore(ssr): mock setInterval for Vue app during SSR Jan 17, 2024
@atinux atinux changed the title chore(ssr): mock setInterval for Vue app during SSR chore(nuxt): mock setInterval for Vue app during SSR Jan 17, 2024
@danielroe danielroe added this to the 3.10 milestone Jan 17, 2024
@danielroe
Copy link
Member

I love it! ❤️

@danielroe danielroe changed the title chore(nuxt): mock setInterval for Vue app during SSR feat(nuxt): mock setInterval for Vue app during SSR Jan 17, 2024
@gaetansenn
Copy link

I love it! ❤️

Was my fault 😂

@danielroe danielroe changed the title feat(nuxt): mock setInterval for Vue app during SSR feat(nuxt): throw error if setInterval is used on server Jan 18, 2024
@danielroe
refactor: move to compat + only error in dev mode

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 3714AB03996F442B
Verified
Learn about vigilant mode
d1bc29c
@danielroe
Merge remote-tracking branch 'origin/main' into dx/interval

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 3714AB03996F442B
Verified
Learn about vigilant mode
ccb5a13
@danielroe
fix: remove export of setInterval

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 3714AB03996F442B
Verified
Learn about vigilant mode
d9c7733
@danielroe
chore: remove unused import

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 3714AB03996F442B
Verified
Learn about vigilant mode
302be27
@danielroe
test: remove setInterval from composable test

Verified

This commit was signed with the committer’s verified signature.
danielroe Daniel Roe
GPG key ID: 3714AB03996F442B
Verified
Learn about vigilant mode
7e50ba1
@danielroe
Merge branch 'main' into dx/interval

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
72d4739
@danielroe danielroe merged commit 90d8518 into main Jan 19, 2024
@danielroe danielroe deleted the dx/interval branch January 19, 2024 22:38
This was referenced Jan 19, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlexLichter TheAlexLichter

@pi0 pi0

@danielroe danielroe

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.

DX: warn or throw error when using setInterval during SSR
5 participants
@atinux @danielroe @gaetansenn @TheAlexLichter @pi0