Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use experimental.viewTransition value for app.viewTransition if none set #25581

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

troyciesco
Copy link
Contributor

πŸ”— Linked issue

#25547

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As part of 3.10 the intention was that if no value was set for app.viewTransition then it should automatically use the value of experimental.viewTransition.

It seems like that wasn't working because the experimental.viewTransition value wasn't available yet in the way it was referenced, so this PR fixes that.

No changes to docs are needed since this was the intended/documented behavior.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Copy link

stackblitz bot commented Feb 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@danielroe danielroe merged commit ced401a into nuxt:main Feb 2, 2024
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.viewTransition does not use the value from experimental.viewTransition
2 participants