Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): allow prefetching urls with query string #25658

Merged
merged 1 commit into from Feb 7, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 6, 2024

πŸ”— Linked issue

resolves #25535

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We may have originally had a reason not to prefetch URLs with a query string but we do not actually use the full URL in the payload path, nor can I see a reason not to prefetch them.

Not sure if you can recall the original reason @pi0?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from pi0 February 6, 2024 09:27
@danielroe danielroe merged commit 25f1787 into main Feb 7, 2024
36 checks passed
@danielroe danielroe deleted the fix/prefetch-query branch February 7, 2024 09:28
This was referenced Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links with query are not preloaded (prerendering)
1 participant