Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): remove undefined keys in route object #25667

Merged
merged 4 commits into from Feb 7, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #25663

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In some case Vue router tries to do things based on a key being defined, even if the value is undefined and it tries to iterate over aliases even if they are undefined.

(We might also fix this in vue-router too.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe we should add a test case that matches the referenced issue's reproduction to the tests array in pages.test.ts?

@danielroe danielroe merged commit 4f3391f into main Feb 7, 2024
34 checks passed
@danielroe danielroe deleted the fix/remove-undefined branch February 7, 2024 10:00
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect property on route entry using pages:extend causes the app to break
2 participants