Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): don't add an extra baseURL on server useRequestURL #25765

Merged
merged 1 commit into from Feb 13, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #25763

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I suspect this was triggered by an upstream change after useRequestURL was introduced, but currently event.path returns full URL so we do not have to add baseURL if app is running with a custom baseURL.

cc: @pi0

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure anything related to these changes in upstream (maybe Nuxt SSR internals?)

BTW seems a good change to me πŸ‘πŸΌ (to also not diverge util behavior specially it has same name!)

PS: We have withBase that can ensure double base won't happen in similar cases.

@danielroe danielroe merged commit 29b338f into main Feb 13, 2024
35 checks passed
@danielroe danielroe deleted the fix/request-url-double-bass branch February 13, 2024 10:30
This was referenced Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useRequestURL() returns double baseUrl on the server side
2 participants