Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): only warn for useId if there is no readable attribute #25770

Merged
merged 1 commit into from Feb 13, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

related: #25755
resolves #25717 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In some cases (such as headless ui or @nuxt/ui), inheritAttrs might be false but attrs are still bound to the root element. In this case the warning is misleading.

This PR only gives a console warning if there is no matching attribute on hydration. (So there should be no warning if the component binds attributes to root element.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Feb 13, 2024
@danielroe
Copy link
Member Author

/trigger release

Copy link
Contributor

πŸš€ Release triggered! You can now install nuxt@npm:nuxt-nightly@pr-25770

@danielroe danielroe merged commit a1c1fda into main Feb 13, 2024
35 checks passed
@danielroe danielroe deleted the fix/use-id-warnings branch February 13, 2024 12:13
This was referenced Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling useId() in template throws an error
1 participant