Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): don't mutate existing component entries when overriding #25786

Merged
merged 1 commit into from Feb 14, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #25787

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously, using Object.assign, we were mutating other components added with addComponent, when overriding with a higher priority component. This change ensures that we just swap our new component into the components array rather than mutating any existing data.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(kit): don't warn when overriding same component fix(kit): don't mutate existing component entries when overriding Feb 14, 2024
@danielroe danielroe merged commit 363bb57 into main Feb 14, 2024
36 checks passed
@danielroe danielroe deleted the fix/component-override branch February 14, 2024 11:48
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtImg: WARN Overriding NuxtImg component.
1 participant