fix(nuxt): mark island specific components with @__PURE__ #25842
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Feb 17, 2024
|
Great, I can't reproduce it anymore 😒... Anyway, let's annotate them first |
huang-julien
changed the title
nuxt-client specific components if feature is not enabled
danielroe
approved these changes
Feb 20, 2024
danielroe
deleted the
fix(nuxt)--don't-add-NuxtTeleportIslandComponent-import-if-feature-is-not-enabled
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Couldn't reproduce it on stackblitz
reproducable by setting
experimental.componentIslandstotruein the basic fixtures and going tolocalhost:3000/islands❓ Type of change
📚 Description
Hello 👋
Seems like Vite don't treeshake the import.
NuxtTeleportIslandComponentis importing#build/components-chunkwhich don't exist if the feature is not enabled.📝 Checklist