Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(nuxt): remove misleading .ts for resolve #25855

Merged
merged 1 commit into from Feb 19, 2024
Merged

docs(nuxt): remove misleading .ts for resolve #25855

merged 1 commit into from Feb 19, 2024

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 19, 2024 •
edited

🔗 Linked issue

#20998

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

From Daniel's comment:

You should not add the .ts extension as this will not be present when you build your module.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio Nuxt Studio
Copy link

nuxt-studio bot commented Feb 19, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview b48ee47

@manniL manniL changed the title docs(modules): remove misleading .ts for resolve docs(nuxt): remove misleading .ts for resolve Feb 19, 2024
huang-julien
huang-julien approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sometimes still make that mistake 😂

@manniL
Copy link
Member Author

manniL commented Feb 19, 2024

I sometimes still make that mistake 😂

Might be a good ESLint rule then? 🤔
Or a dev warning in resolve?

@danielroe danielroe merged commit 9326b7a into main Feb 19, 2024
4 of 7 checks passed
@danielroe danielroe deleted the manniL-patch-1 branch February 19, 2024 10:36
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@huang-julien huang-julien huang-julien approved these changes

Assignees
No one assigned
Labels
3.x documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manniL @danielroe @huang-julien