Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): strip extensions only for existing files #25965

Merged
merged 2 commits into from Feb 27, 2024
Merged

fix(nuxt): strip extensions only for existing files #25965

merged 2 commits into from Feb 27, 2024

Conversation

productdevbook
Copy link
Sponsor Member

@productdevbook productdevbook commented Feb 26, 2024 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

unjs/nitro#2139 I thought it would be nice if we used the same algorithm in both places.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

danielroe
danielroe approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe changed the title refactor: import types stripExtension fix(nuxt): strip extensions only for existing files Feb 26, 2024
@danielroe danielroe merged commit 40c3a39 into nuxt:main Feb 27, 2024
35 checks passed
@productdevbook productdevbook deleted the refactor-add-declaration branch February 27, 2024 09:12
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@productdevbook @danielroe