docs: add domEnvironment option to example #25972
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Live Preview ready!
|
danielroe
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No issue, just a minor addition to the documentation.
❓ Type of change
📚 Description
The Testing Guide mentions that it is possible to choose between happy-dom and jsdom, but it did not mention how. Since I was using jsdom before and happy-dom was not installed, all my tests failed. I had to go through the source code to discover the
domEnvironmentoption to fix this.Maybe I'm missing something, but it feels like the Testing Guide could in general use a bit more detail here and there.
📝 Checklist